Bugfix/global filtering #187
Open
+93
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11374655042Details
💛 - Coveralls |
mcarans
approved these changes
Oct 16, 2024
|
Once we release the changes I made in hdx-python-country this will be ready to release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the filter on food security to include all countries, and added a country filter to the funding data. I checked the IPC p-code mappings and they're pretty good. I had to add a couple extra matching rules to get some countries to match.
There are just a few mismatched units in GHA that I either want to match to admin 1 or add to the admin_fuzzy_dont list. @mcarans I think we should change admin_fuzzy_don't to include iso codes so we don't eliminate fuzzy matching globally for common words like "Central". Or we could make the mappings a little more flexible to allow us to match to XXX units. Which do you think makes more sense?